From 24e68f8eb59eae886f6f0c8280f48d992be280d5 Mon Sep 17 00:00:00 2001 From: Seungbae Yu Date: Thu, 15 Sep 2022 00:19:12 +0900 Subject: [PATCH] file_snapshot: do defer after os.Open succeed (#519) --- file_snapshot.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file_snapshot.go b/file_snapshot.go index e4d1ea4f9..ba238f914 100644 --- a/file_snapshot.go +++ b/file_snapshot.go @@ -424,11 +424,11 @@ func (s *FileSnapshotSink) Close() error { if !s.noSync && runtime.GOOS != "windows" { // skipping fsync for directory entry edits on Windows, only needed for *nix style file systems parentFH, err := os.Open(s.parentDir) - defer parentFH.Close() if err != nil { s.logger.Error("failed to open snapshot parent directory", "path", s.parentDir, "error", err) return err } + defer parentFH.Close() if err = parentFH.Sync(); err != nil { s.logger.Error("failed syncing parent directory", "path", s.parentDir, "error", err)