Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging ssh bastion #123

Merged
merged 2 commits into from Aug 18, 2022
Merged

Logging ssh bastion #123

merged 2 commits into from Aug 18, 2022

Conversation

lbajolet-hashicorp
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp commented Aug 12, 2022

In order to make it easier to follow when connecting with a bastion to a SSH host, we add another layer of logging related to these actions.

Related to: hashicorp/packer#11719

When running a config that specifies a SSH communicator with a bastion
without any authentication option, the proposed resolution would only
include password or private key, and left agent authentication out of
the error message.

This commit adds it to the list of options to resolve it.
@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner August 12, 2022 14:31
Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. I have one nit but otherwise good to go.

sdk-internals/communicator/ssh/connect.go Outdated Show resolved Hide resolved
When a SSH bastion is used for connecting to a target, the operation is
done completely silently, making it hard to understand if it is working
as intended.

To make it easier to follow the path that the command is taking, we add
a few more INFO/DEBUG logs that parrot the actions it takes for
connecting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants