Make ed25519 keys generated by Packer serialize in the format usable by ssh #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nikolaymatrosov
force-pushed
the
ssh-usable-ed25519
branch
from
4fc3338
to
ecd0749
Compare
lbajolet-hashicorp
approved these changes
Aug 12, 2022
There was a problem hiding this comment.
Hey @nikolaymatrosov,
Great job on the research (and providing the links to the docs/specs, that's very helpful in understanding the change) and the implementation. The code looks good to me, I think we can merge this right away.
Thank you very much for this contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said in the method comment, the method produced the key in a format incompatible with ssh. As a result, the key Packer SDK created resulted in the error
Load key "id_ed25519": invalid format.I found the format description and fixed the generation algorithm to fix this problem:
As
ed25519keys are getting more popular, I think it would be helpful to have them serialize correctly.