ssh: only rely on timeout/retries if one is set #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbajolet-hashicorp
changed the title
nywilken
approved these changes
Jul 27, 2022
|
Good call on the nit! I'll merge this once tests pass |
In a configuration, when either the SSH timeout or the SSH handshake retries are set, the other attribute would also be set to its default value. This in turn could cause a problem where a user expects his choice to be the one that makes the final decision to abort, but in the end this choice could cause the build to be cancelled independently as the other setting may cause a premature cancellation. To avoid this, we clarify the documentation, and ensure that when one is set, the other will be ignored.
lbajolet-hashicorp
force-pushed
the
ssh_timeout_retries_defaults
branch
from
78d4c93
to
aa3cc81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a configuration, when either the SSH timeout or the SSH handshake
retries are set, the other attribute would also be set to its default
value.
This in turn could cause a problem where a user expects his choice to be
the one that makes the final decision to abort, but in the end this
choice could cause the build to be cancelled independently as the other
setting may cause a premature cancellation.
To avoid this, we clarify the documentation, and ensure that when one is
set, the other will be ignored.
Closes: #87