Provision SSHPublicKey while use custom SSH Private key #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nywilken ! |
|
Hi @GennadySpb this change looks good to me. I just want to figure out if we need some documentation to denote this behavior. |
nywilken
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
@GennadySpb thanks for this enhancement. The change does make sense to have as part of the SDK. Please not that builders will not automatically upload the generated PubKey, as the majority of the builders are set to not set any SSH public keys settings when a private key is specified.
If you have a particular builder that you plan to use this feature with you will need to open a separate PR for it on its respective repository.
|
Thank you @nywilken ! I will keep it in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100