Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all shells: Pass env vars through a key value store #98

Merged
merged 4 commits into from Feb 16, 2022
Merged

all shells: Pass env vars through a key value store #98

merged 4 commits into from Feb 16, 2022

Conversation

azr
Copy link
Contributor

@azr azr commented Feb 15, 2022 •
edited

  • feature
  • docs

@azr azr mentioned this pull request Feb 15, 2022
Merged
9 tasks
@azr azr marked this pull request as ready for review February 15, 2022 12:48
@azr azr requested a review from a team as a code owner February 15, 2022 12:48
nywilken
nywilken approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice add. She we consider deprecating the environment_vars field?

@azr
Copy link
Contributor Author

azr commented Feb 16, 2022

Ehm, good question, I would think that environment_vars sounds pretty widely used and should stay there forever.

@azr azr merged commit f7d4bf8 into main Feb 16, 2022
@azr azr deleted the azr/shell-map-env branch February 16, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@azr @nywilken