Implement callbacks for HTTP Server #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
flx5
changed the title
|
Hi @flx5 thanks again for making this change, and apologies for the delayed response here. Like the screenshot PR this is an interesting change and something that we think would be helpful to improving the debugging experience work we are envisioning for the future. Unfortunately at this time this is not a feature we have the cycles to take on. So I am going to close this PR but when ready I will gladly ping the thread and see if there is anything we can do to get this change merged and fully supported. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements callbacks for requests to the http server.
That way plugins can inspect requests if required.
Additionally a logging callback is added which should resolve #50.
Please let me know if any changes are required.