Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

communicator: fix SSH config typo #124

Merged
merged 1 commit into from Aug 18, 2022
Merged

communicator: fix SSH config typo #124

merged 1 commit into from Aug 18, 2022

Conversation

lbajolet-hashicorp
Copy link
Contributor

Fix small typo in the comment for an SSH configuration option where algorithm was misspelled.

@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner August 18, 2022 15:36
Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nywilken
Copy link
Member

Oh this is a shared partial that needs to be re-generated before merging.

@lbajolet-hashicorp
Copy link
Contributor Author

Yes, the tests do point it out; I've amended this commit, if tests succeed, I'll merge this PR, thanks for the review!

@nywilken
Copy link
Member

You linter is out of date. I pushed a fixed to main a few days ago. Can you please pull down the latest main and rebase.

@lbajolet-hashicorp
Copy link
Contributor Author

Hmmm, that's weird, I have fetched and rebased on top of main as it stands. Is there anything else I should be doing for the linter to be up-to-date? I basically ran make generate in order to generate the latest version of the partials, is it as expected?

@nywilken nywilken added documentation Improvements or additions to documentation docs labels Aug 18, 2022
@nywilken nywilken merged commit 42da5e2 into main Aug 18, 2022
@nywilken nywilken deleted the ssh_comment_typo_fix branch August 18, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants