Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fixup GHA deprecation warnings #14905

Closed
shoenig opened this issue Oct 17, 2022 · 1 comment · Fixed by #15271
Closed

build: fixup GHA deprecation warnings #14905

shoenig opened this issue Oct 17, 2022 · 1 comment · Fixed by #15271
Labels
theme/build-infrastructure

Comments

@shoenig
Copy link
Member

shoenig commented Oct 17, 2022

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Unfortunately, actions/setup-go@v3 neither fixes all of the deprecation, and it breaks $GOROOT behavior we depend on.

We need actions/setup-go#276 and actions/setup-go#278 to be fixed,
then we need a new release of https://github.com/magnetikonline/action-golang-cache pointed at setup-go@v4.
shoenig added a commit that referenced this issue Nov 16, 2022
@shoenig
ci: use hashicorp/setup-golang for setting up go compiler, cache
580060e 
This PR changes test-core to make use of

https://github.com/hashicorp/setup-golang

to consolidate the setting up of the Go compiler and the Go modules cache
used for the CI job.

Fixes: #14905
@shoenig shoenig mentioned this issue Nov 16, 2022
Merged
shoenig added a commit that referenced this issue Nov 16, 2022
@shoenig
ci: use hashicorp/setup-golang for setting up go compiler, cache
ec7abc2 
This PR changes test-core to make use of

https://github.com/hashicorp/setup-golang

to consolidate the setting up of the Go compiler and the Go modules cache
used for the CI job.

Fixes: #14905
shoenig added a commit that referenced this issue Nov 17, 2022
@shoenig
ci: use hashicorp/setup-golang for setting up go compiler, cache (#15271
732adae 
)

This PR changes test-core to make use of

https://github.com/hashicorp/setup-golang

to consolidate the setting up of the Go compiler and the Go modules cache
used for the CI job.

Fixes: #14905
This was referenced Nov 17, 2022
Closed
Merged
Merged
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
theme/build-infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: use hashicorp/setup-golang for setting up go compiler, cache hashicorp/nomad
1 participant
@shoenig