Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit transport protocols in state errors: TCP or UDP #258

Merged
merged 1 commit into from Feb 25, 2022

Conversation

krastin
Copy link
Contributor

@krastin krastin commented Feb 9, 2022

As described in issue #234 , when troubleshooting connectivity issues, end-users routinely get confused that Memberlist ping messages are ICMP packets.

I'm basing my edits on the fact that Memberlist pings were already referred to as UDP Ping here:

m.logger.Printf("[DEBUG] memberlist: Failed UDP ping: %v (timeout reached)", node)

Anytime there is a mention of ping, I've added explicitly whether this is an UDP or TCP segment.

@krastin krastin linked an issue Feb 9, 2022 that may be closed by this pull request
@krastin krastin requested a review from a team February 10, 2022 09:08
Copy link
Contributor

@kisunji kisunji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change! LGTM

@kisunji kisunji merged commit 696ff46 into hashicorp:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More user-friendly error message for connectivity issues
2 participants