Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node pointer passed to NodeJoin channel event delegate has no meta #255

Open
CDespeaux opened this issue Jan 18, 2022 · 1 comment
Open

Comments

@CDespeaux
Copy link

CDespeaux commented Jan 18, 2022

I'm trying to receive events via the Channel Event Delegate. At times, there is no meta data associated with the node when I use the Node pointer provided by NodeEvent but yet if I find the node based on the name in the memberlist it contains the meta data. This always seems to happen when the node that joins is the node receiving the channel event. The Node pointer provided by NodeEvent also points to a different memory location than the memory address associated with the node found by iterating the memberlist. It doesn't make sense to me that I would have to search the memberlist in order to access the meta data. What gives? It looks NodeEvent is providing an incomplete copy. I set the meta data in the node immediately before calling cluster join.

@dnephin
Copy link
Contributor

dnephin commented Jan 18, 2022

Thank you for raising this issue! I think this may be related to the data race I found in #238, or the data race identified here: #232 (review).

I haven't looked into this in much detail, but it seems like one or both of those could cause the problem you describe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants