Fix for compound messages containing >255 messages. #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
2 tasks
|
This looks reasonable at first glance. I'm very curious how you found this. Can you give any details on the situation? |
We're experiencing this when running large Cortex clusters and we found it after some debugging. |
markan
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ever more than 255 messages are put into a compound message, then the resulting packet will be malformed leading to errors on the receiving end such as:
This change sends multiple packets if required. The alternative approach would be to limit the number of messages that
GetBroadcastscan return, by e.g. passing in a maximum number of messages, but this would require changing theDelegateinterface, possibly breaking downstream code.