Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't insert default values into null objects #567

Merged
merged 3 commits into from Nov 7, 2022

Conversation

liamcervante
Copy link
Member

Relates to hashicorp/terraform#32157

This will fix the root cause of the above issue. An important thing to note is the distinction between replacing null values with defaults and inserting default values into null values. The former is an expected and required behaviour while the latter is unwanted. This PR leaves the former intact (and there are tests that show this), while it adds tests that make sure the latter doesn't happen and fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants