gohcl: Fix docs about supported types for blocks. #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This commit fixes a clause in the `gohcl` package documentation which incorrectly states that HCL blocks could be decoded into `hcl.Body` and `hcl.Block` types. It also removes some code paths in `decodeBlockToValue()` that _appeared_ to handled these cases. In practice, these paths were unreachable anyway due to various reflection-based type checks made before `decodeBlockToValue()` is called.
|
Thanks! I've replaced this commit with a signed commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a clause in the
gohclpackage documentation which incorrectly states that HCL blocks could be decoded intohcl.Bodyandhcl.Blocktypes.It also removes some code paths in
decodeBlockToValue()that appeared to handled these cases. In practice, these paths were unreachable anyway due to various reflection-based type checks made beforedecodeBlockToValue()iscalled.
/cc @apparentlymart
Fixes #505