Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoder: Improve SignatureAtPos accuracy #235

Open
dbanck opened this issue Mar 16, 2023 · 0 comments
Open

decoder: Improve SignatureAtPos accuracy #235

dbanck opened this issue Mar 16, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@dbanck
Copy link
Member

dbanck commented Mar 16, 2023

Background

In #135, we added support function signature help.

As Radek mentioned, it doesn't consider the schema, which means that we provide signature help in all contexts/expressions, regardless of whether function calls are expected there or not.

For example, you get help for list or map types in Terraform < 0.15, where functions with the same names exist.

CleanShot 2023-03-16 at 16 45 37@2x

Proposal

  • Improve SignatureAtPos to take the schema/outer most expression into account before providing signature help
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant