Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoder/schema: Report completed attributes with Kind per constraint #229

Open
radeksimko opened this issue Mar 13, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@radeksimko
Copy link
Member

Context

Currently when we complete any attribute, either 1st class

2023-03-13 09 06 25

or within an Object (#203)

TODO

or key within a Map (#199)

Screenshot 2023-03-13 at 09 09 37

the reported Kind is always broad "attribute", regardless of the attribute's constraint/type (e.g. string, number, ...).

Proposal

Consider replacing the broad "attribute" kind with the kind relevant to the constraint type, as available in

BoolCandidateKind
KeywordCandidateKind
ListCandidateKind
MapCandidateKind
NumberCandidateKind
ObjectCandidateKind
SetCandidateKind
StringCandidateKind
TupleCandidateKind
TraversalCandidateKind

This could provide more helpful completion experience where the user can more quickly do "eye scan" through the icons and visually filter by types.


Notes

For consistency we may want to do something similar for blocks, which can also be of different types, although these would be just one of the following:

  • object
  • list
  • set
  • map
@radeksimko radeksimko added the enhancement New feature or request label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant