New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support releases-api returned content-type #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com>
Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com>
radeksimko
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was referenced May 10, 2022
2 tasks
shoenig
pushed a commit
to shoenig/hc-install
that referenced
this pull request
May 10, 2022
* Support releases-api returned content-type Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com> * Set Go to v1.18 when building consul from source Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com> * remove unused variables Co-authored-by: Radek Simko <radek.simko@gmail.com>
shoenig
added a commit
to shoenig/hc-install
that referenced
this pull request
May 10, 2022
Support releases-api returned content-type (hashicorp#57)
inkel
added a commit
to grafana/terraform-provider-grafana
that referenced
this pull request
May 12, 2022
This package is responsible for installing Terraform to perform acceptance tests. Since the announcement of the HashiCorp Releases API [1] 3 days ago our CI is broken. After further inspection, I've found that this package was indeed the culprit, and that we need to upgrade the package to 0.3.2 after hashicorp/hc-install#57 got merged. 1: https://www.hashicorp.com/blog/announcing-the-hashicorp-releases-api
inkel
added a commit
to grafana/terraform-provider-grafana
that referenced
this pull request
May 12, 2022
* Upgrade indirect hc-install package This package is responsible for installing Terraform to perform acceptance tests. Since the announcement of the HashiCorp Releases API [1] 3 days ago our CI is broken. After further inspection, I've found that this package was indeed the culprit, and that we need to upgrade the package to 0.3.2 after hashicorp/hc-install#57 got merged. 1: https://www.hashicorp.com/blog/announcing-the-hashicorp-releases-api * Use version 1.45 of golangci-lint and not latest Version 1.46+ throws a bunch of errors that doesn't really stop this from working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the content-type checks to include the type returned from the releases api.
Edit: Also set Go version to 1.18 when building Consul from source.
Closes #56
Signed-off-by: Scott Macfarlane smacfarlane@hashicorp.com