Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove method is calling the wrong callback #83

Closed
rtksrubie opened this issue Jan 10, 2021 · 2 comments
Closed

Remove method is calling the wrong callback #83

rtksrubie opened this issue Jan 10, 2021 · 2 comments

Comments

@rtksrubie
Copy link

this line in the Remove method

golang-lru/lru.go

Line 170 in 80c9821

c.onEvicted(k, v)

should instead be

	c.onEvictedCB(k, v)
@rtksrubie
Copy link
Author

@yigongliu-concur I think this is related to your most recent changes #80

@yigongliu-concur yigongliu-concur mentioned this issue Jan 10, 2021
Merged
@yigongliu-concur
Copy link
Contributor

thanks for pointing it out. please review fix PR (#84)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@irenarindos @rtksrubie @yigongliu-concur