rework lru's external registered callback invocation to avoid concurr… #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ency issue such as possible deadlock
|
Great! Thanks for the approval, a good start for the new year:).
…On Mon, Jan 4, 2021 at 6:05 AM Jeff Mitchell ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good, thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#80 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR3BVEGFN7EH6QDXOPWQFSLSYHDMDANCNFSM4UOZ5RKQ>
.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rework LruCache's invocation of externally registered eviction callback. current code forwards external callback directly into simplelru.LRU, which will invoke the external callback while holding lock at LruCache. this could lead to concurrency issues such as possible deadlock.
redo the invocation by passing a internal eviction callback to simplelru.LRU to buffer the evicted keys/vals, and only send them thru external eviction callback after/outside LruCache locks' critical section.
running benchmark shows no performance degrade.