Code quality improvements #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paskal
commented
May 9, 2020
paskal
commented
- Add golangci-lint configuration with sane set of checks
- Fix discovered issues
- Add GitHub Actions workflow for test and build and linter run
|
|
jefferai
reviewed
May 11, 2020
|
Thanks for updating! In the future please refrain from force-pushing as it doesn't allow reviewers to check just the changes you're making in response to review without going back and having to evaluate the whole thing again. |
jefferai
approved these changes
May 11, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.