Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease String shouldn't always be treated as lower version #102

Open
Maimonator opened this issue Sep 11, 2022 · 0 comments
Open

Prerelease String shouldn't always be treated as lower version #102

Maimonator opened this issue Sep 11, 2022 · 0 comments

Comments

@Maimonator
Copy link

Hey,
I've found some irregularity where I have the following two versions for tcpdump
4.9.3-4ubuntu0.1
4.9.3

Using the example code from the readme we get that 4.9.3 is greater than 4.9.3-4ubuntu0.1 even though that's not the case
Link to playground to see my tests.

I'm pretty sure that 4ubuntu0.1 doesn't mean it's a prerelease version and it's a widely used suffix.
In other compiled binaries for ubuntu.

I'm not sure what's the correct approach to solve this, but I was wondering whether we should narrow down the behavior when evaluating the prerelease string.
WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant