Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CV failure notification type #549

Merged
merged 3 commits into from Oct 24, 2022

Conversation

rexredinger
Copy link
Contributor

Description

Testing plan

N/A

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" TF_ACC="1" go test ./... -v -tags=integration -run TestFunctionsAffectedByChange

...

@rexredinger rexredinger added the enhancement New feature or request label Oct 13, 2022
@rexredinger rexredinger requested a review from a team as a code owner October 13, 2022 17:17
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog entry? Currently there are no unreleased changes (it should say v1.11.0), so it would be an awesome favor if you could update that as well ❤️

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sebasslash sebasslash merged commit cdcd0b6 into main Oct 24, 2022
@sebasslash sebasslash deleted the support_cv_notifications branch October 24, 2022 23:09
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants