Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose optional query param #529

Merged
merged 1 commit into from Sep 13, 2022
Merged

Conversation

laurenolivia
Copy link
Contributor

@laurenolivia laurenolivia commented Sep 8, 2022

Description

This PR exposes the option to pass a query parameter to filter an organization by name or email.

Testing plan

  1. Running tests locally should suffice.

External links

Organizations API Docs

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" TF_ACC="1" go test ./... -v -tags=integration -run TestFunctionsAffectedByChange

...

@laurenolivia laurenolivia requested a review from a team as a code owner September 8, 2022 18:51
@laurenolivia laurenolivia force-pushed the laurenolivia/add-org-query-params branch 3 times, most recently from 4b6a916 to c0c5768 Compare September 9, 2022 19:03
Copy link
Contributor

@annawinkler annawinkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! Could you please add an update to the Changelog?

@laurenolivia laurenolivia force-pushed the laurenolivia/add-org-query-params branch from c0c5768 to 11d1851 Compare September 12, 2022 19:22
@laurenolivia
Copy link
Contributor Author

@annawinkler Added CHANGELOG update to this PR 👍

Copy link
Contributor

@annawinkler annawinkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Looks good!

@laurenolivia laurenolivia merged commit f16c6cc into main Sep 13, 2022
@laurenolivia laurenolivia deleted the laurenolivia/add-org-query-params branch September 13, 2022 14:15
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants