Create a TaskResult object for the client #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit actually creates a TaskResult struct. Without this change users will receive nil pointer errors when attempting to use this part of the client.
glennsarti
force-pushed
the
gs/actually-create-task-result
branch
from
c2a1b2c
to
6297e2d
Compare
annawinkler
approved these changes
Aug 30, 2022
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
|
@glennsarti very nit, but it looks like those services are listed alphabetically, and |
|
@laurenolivia Raised PR #522 to reorder things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit actually creates a TaskResult struct. Without this change users will receive
nil pointer errors when attempting to use this part of the client.
Testing plan
N/A