Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beta comments and skipBeta from List Runs Options #472

Merged
merged 7 commits into from Aug 24, 2022

Conversation

mjyocca
Copy link
Contributor

@mjyocca mjyocca commented Jul 20, 2022

Description

Remove mentions of beta for recently added List Runs options and remove skipIfBeta

Testing plan

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" TF_ACC="1" go test ./... -v -tags=integration -run TestFunctionsAffectedByChange

...

@mjyocca mjyocca requested a review from a team as a code owner July 20, 2022 19:54
sebasslash
sebasslash previously approved these changes Jul 20, 2022
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

brandonc
brandonc previously approved these changes Jul 28, 2022
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will these be added to the API docs?

@mjyocca
Copy link
Contributor Author

mjyocca commented Jul 28, 2022

will these be added to the API docs?

@brandonc these changes correspond to the workspace runs API Docs

@annawinkler
Copy link
Contributor

Added DO NOT MERGE label so we don't merge this PR until the feature flag has been removed from TFC.

@mjyocca
Copy link
Contributor Author

mjyocca commented Aug 23, 2022

Added DO NOT MERGE label so we don't merge this PR until the feature flag has been removed from TFC.

Feature Flag has been removed and we're ready to ship 🚀

aaabdelgany
aaabdelgany previously approved these changes Aug 23, 2022
brandonc
brandonc previously approved these changes Aug 23, 2022
@mjyocca
Copy link
Contributor Author

mjyocca commented Aug 23, 2022

Working on some integration test fixes

@mjyocca mjyocca dismissed stale reviews from brandonc and aaabdelgany via e3c9d0b August 24, 2022 04:52
aaabdelgany
aaabdelgany previously approved these changes Aug 24, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@mjyocca mjyocca merged commit ca80c89 into main Aug 24, 2022
@mjyocca mjyocca deleted the mjyocca/runs-list-param-cleanup branch August 24, 2022 16:41
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants