Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Run and Workspace Run Tasks for Pre-plan Run Tasks #469

Merged
merged 1 commit into from Aug 1, 2022
Merged

Update Run and Workspace Run Tasks for Pre-plan Run Tasks #469

merged 1 commit into from Aug 1, 2022

Conversation

glennsarti
Copy link
Contributor

@glennsarti glennsarti commented Jul 18, 2022 •
edited

Description

This commit updates the client for the new Pre-plan Run tasks:

  • New run statuses; FetchingCompleted, Queuing which are ephemeral and will rarely be seen.
    PrePlanRunning and PrePlanCompleted are for the pre-plan tasks
  • Add missing Run Status Time Stamps
  • New Task stage; PrePlan
  • Ability to set/update the stage for a Workspace Run Task. This is a beta feature and must
    be opted into. However it is optional and is not a breaking API change.
  • Adds additional Workspace Run Tasks tests which are gated behind the BETA flag. Note that
    the original tests still remain to affirm that this commit does not change any existing
    behaviour.

Testing plan

Run the acceptance tests against a TFC/TFE instance with the pre-plan feature flag enabled

External links

Output from tests

With go test -v ./... -tags=integration -run TestWorkspaceRunTasks -count=1

=== RUN   TestWorkspaceRunTasksCreate
=== RUN   TestWorkspaceRunTasksCreate/attach_run_task_to_workspace
=== RUN   TestWorkspaceRunTasksCreate/attach_run_task_to_workspace/ensure_run_task_is_deserialized_properly
--- PASS: TestWorkspaceRunTasksCreate (3.39s)
    --- PASS: TestWorkspaceRunTasksCreate/attach_run_task_to_workspace (0.64s)
        --- PASS: TestWorkspaceRunTasksCreate/attach_run_task_to_workspace/ensure_run_task_is_deserialized_properly (0.00s)
=== RUN   TestWorkspaceRunTasksCreateBeta
=== RUN   TestWorkspaceRunTasksCreateBeta/attach_run_task_to_workspace
=== RUN   TestWorkspaceRunTasksCreateBeta/attach_run_task_to_workspace/ensure_run_task_is_deserialized_properly
--- PASS: TestWorkspaceRunTasksCreateBeta (3.28s)
    --- PASS: TestWorkspaceRunTasksCreateBeta/attach_run_task_to_workspace (0.60s)
        --- PASS: TestWorkspaceRunTasksCreateBeta/attach_run_task_to_workspace/ensure_run_task_is_deserialized_properly (0.00s)
=== RUN   TestWorkspaceRunTasksList
=== RUN   TestWorkspaceRunTasksList/with_no_params
--- PASS: TestWorkspaceRunTasksList (5.18s)
    --- PASS: TestWorkspaceRunTasksList/with_no_params (0.36s)
=== RUN   TestWorkspaceRunTasksRead
=== RUN   TestWorkspaceRunTasksRead/by_ID
=== RUN   TestWorkspaceRunTasksRead/by_ID/ensure_run_task_is_deserialized
=== RUN   TestWorkspaceRunTasksRead/by_ID/ensure_workspace_is_deserialized
--- PASS: TestWorkspaceRunTasksRead (3.48s)
    --- PASS: TestWorkspaceRunTasksRead/by_ID (0.25s)
        --- PASS: TestWorkspaceRunTasksRead/by_ID/ensure_run_task_is_deserialized (0.00s)
        --- PASS: TestWorkspaceRunTasksRead/by_ID/ensure_workspace_is_deserialized (0.00s)
=== RUN   TestWorkspaceRunTasksUpdate
=== RUN   TestWorkspaceRunTasksUpdate/rename_task
--- PASS: TestWorkspaceRunTasksUpdate (3.79s)
    --- PASS: TestWorkspaceRunTasksUpdate/rename_task (0.56s)
=== RUN   TestWorkspaceRunTasksUpdateBeta
=== RUN   TestWorkspaceRunTasksUpdateBeta/update_task
--- PASS: TestWorkspaceRunTasksUpdateBeta (3.90s)
    --- PASS: TestWorkspaceRunTasksUpdateBeta/update_task (0.51s)
=== RUN   TestWorkspaceRunTasksDelete
=== RUN   TestWorkspaceRunTasksDelete/with_valid_options
=== RUN   TestWorkspaceRunTasksDelete/when_the_workspace_run_task_does_not_exist
=== RUN   TestWorkspaceRunTasksDelete/when_the_workspace_does_not_exist
--- PASS: TestWorkspaceRunTasksDelete (4.10s)
    --- PASS: TestWorkspaceRunTasksDelete/with_valid_options (0.52s)
    --- PASS: TestWorkspaceRunTasksDelete/when_the_workspace_run_task_does_not_exist (0.24s)
    --- PASS: TestWorkspaceRunTasksDelete/when_the_workspace_does_not_exist (0.25s)
PASS
ok      github.com/hashicorp/go-tfe     27.384s
?       github.com/hashicorp/go-tfe/examples/organizations      [no test files]
?       github.com/hashicorp/go-tfe/examples/workspaces [no test files]
?       github.com/hashicorp/go-tfe/mocks       [no test files]

@glennsarti glennsarti self-assigned this Jul 18, 2022
@glennsarti glennsarti force-pushed the gs/add-pre-plan branch 3 times, most recently from efed688 to 270f10b Compare July 20, 2022 03:43
@glennsarti glennsarti changed the title {DO NOT MERGE} Update for Pre-plan Run Tasks Update Run and Workspace Run Tasks for Pre-plan Run Tasks Jul 20, 2022
@glennsarti glennsarti marked this pull request as ready for review July 20, 2022 03:46
@glennsarti glennsarti requested a review from a team as a code owner July 20, 2022 03:46
@glennsarti
Copy link
Contributor Author

Note that while this is adding "beta" features, the APIs for these are basically set in stone. And these changes are not breaking, and opt-in.

@glennsarti glennsarti added the enhancement New feature or request label Jul 20, 2022
Uk1288
Uk1288 reviewed Jul 25, 2022
View reviewed changes
workspace_run_task.go Outdated Show resolved Hide resolved
Uk1288
Uk1288 reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@Uk1288 Uk1288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 I was able to smoke test this on my local. Nice work!

Uk1288
Uk1288 previously approved these changes Jul 26, 2022
View reviewed changes
@glennsarti
Update Run and Workspace Run Tasks for Pre-plan Run Tasks
f602464 
This commit updates the client for the new Pre-plan Run tasks:
* New run statuses; FetchingCompleted, Queuing which are ephemeral and will rarely be seen.
  PrePlanRunning and PrePlanCompleted are for the pre-plan tasks
* Add missing Run Status Time Stamps
* New Task stage; PrePlan
* Ability to set/update the stage for a Workspace Run Task. This is a beta feature and must
  be opted into. However it is optional and is not a breaking API change.
* Adds additional Workspace Run Tasks tests which are gated behind the BETA flag. Note that
  the original tests still remain to affirm that this commit does not change any existing
  behaviour.
@glennsarti glennsarti requested a review from Uk1288 July 27, 2022 01:45
@glennsarti
Copy link
Contributor Author

Hi @Uk1288 . I had to rebase again (merge conflict in changelog). Can you do me a favour, can you approve and merge this for me. Unfortunately it's very common that I have to rebase approved PRs due to changelog conflicts and adds days for me to get work in. Thanks!

@glennsarti glennsarti merged commit ce0f146 into main Aug 1, 2022
@glennsarti glennsarti deleted the gs/add-pre-plan branch August 1, 2022 01:48
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

@glennsarti glennsarti mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uk1288 Uk1288 Uk1288 approved these changes

Assignees

@glennsarti glennsarti

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glennsarti @Uk1288