Add Name to the Oauth Client Payload #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrettclark
force-pushed
the
barrettclark/add-name-to-oauth-client
branch
from
95c75bf
to
d1b630f
Compare
sebasslash
requested changes
Jul 15, 2022
oauth_client.go
Outdated
| @@ -73,6 +73,7 @@ type OAuthClient struct { | |||
| HTTPURL string `jsonapi:"attr,http-url"` | |||
| Key string `jsonapi:"attr,key"` | |||
| RSAPublicKey string `jsonapi:"attr,rsa-public-key"` | |||
| Name string `jsonapi:"attr,name"` | |||
There was a problem hiding this comment.
Given the default value of this field is null, we should make this a pointer.
oauth_client_integration_test.go
Outdated
| @@ -109,6 +109,7 @@ func TestOAuthClientsCreate(t *testing.T) { | |||
| oc, err := client.OAuthClients.Create(ctx, orgTest.Name, options) | |||
| require.NoError(t, err) | |||
| assert.NotEmpty(t, oc.ID) | |||
| assert.Empty(t, oc.Name) | |||
There was a problem hiding this comment.
Nice - when I make Name a pointer it does actually come through as null rather than "".
barrettclark
force-pushed
the
barrettclark/add-name-to-oauth-client
branch
from
d1b630f
to
1a4f8aa
Compare
sebasslash
approved these changes
Jul 15, 2022
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The oauth-clients endpoint returns the name attribute of each OAuth Client, but the OAuthClient struct doesn't expose this attribute. This pull request adds the Name field to the OAuthClient struct.
Fixes #461
Testing plan
This is how you see the name in the Oauth Client payload:
In order to run the integration test you also need to do the first two steps from above.
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.