Replace deprecated GET api for registry modules #464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The go-client employs the deprecated API (GET /registry-modules/show/:organization_name/:name/:provider) to GET published modules. The API works only for private modules.
This PR replaces the deprecated API with the newer API: GET /organizations/:organization_name/registry-modules/:registry_name/:namespace/:name/:provider which works for both public and private modules.
My initial thought was to replace the
RegistryModuleID
inRead(ctx context.Context, moduleID RegistryModuleID) (*RegistryModule, error)
with:but this would lead to a breaking change.
To allow for backward compatibility I went with the current solution which just extends the
RegistryModuleID
.Testing plan
Read
method to get modules. Private module is returned successfully while public module returns not foundExternal links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.
Dependent PR
#460 is blocked by this PR