add agent data source #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenolivia
commented
Jul 6, 2022
laurenolivia
force-pushed
the
laurenolivia/add-agent-data-source
branch
from
113e384
to
2c1cb2b
Compare
laurenolivia
force-pushed
the
laurenolivia/add-agent-data-source
branch
from
35977f5
to
84413bc
Compare
laurenolivia
force-pushed
the
laurenolivia/add-agent-data-source
branch
from
84413bc
to
cd5c837
Compare
sebasslash
previously requested changes
Jul 27, 2022
| } | ||
|
|
||
| u := fmt.Sprintf("agents/%s", url.QueryEscape(agentID)) | ||
| req, err := s.client.NewRequest("GET", u, nil) |
There was a problem hiding this comment.
I think we should pass options here instead of nil.
There was a problem hiding this comment.
Possibly another sign that this method isn't needed! 😄
There was a problem hiding this comment.
@sebasslash 👍
@nfagerlund Can you elaborate on why it's a sign that the method, possibly, isn't needed❔
nfagerlund
previously requested changes
Jul 28, 2022
| } | ||
|
|
||
| u := fmt.Sprintf("agents/%s", url.QueryEscape(agentID)) | ||
| req, err := s.client.NewRequest("GET", u, nil) |
There was a problem hiding this comment.
Possibly another sign that this method isn't needed! 😄
laurenolivia
commented
Aug 3, 2022
brandonc
requested changes
Aug 10, 2022
|
Tests passing 🎉 |
brandonc
reviewed
Aug 10, 2022
brandonc
requested changes
Aug 11, 2022
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new datasource to the Client. The purpose is to allow users to Read, List agents. Please see the Agent Pool and Agents documentation, linked below, for more information.
Please be aware that this PR downloads the tfc-agent binary, which only supports Linux AMD64 architecture.
Testing plan
-- or --
External links
Output from tests
PASS
ok github.com/hashicorp/go-tfe
See example of how to run integration tests, below. Refer to TESTS.md for further details.