New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally send json outputs when creating state versions #452
Conversation
881bdd3
to
9aa0626
Compare
@@ -186,6 +186,8 @@ func TestStateVersionsCreate(t *testing.T) { | |||
t.Fatal(err) | |||
} | |||
|
|||
// TODO: check state outputs for the ones we sent in JSONStateOutputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this TODO be resolved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, not until the API changes are merged.
507f167
to
138802f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Hooray for this PR!
Co-authored-by: Anna Winkler <3526523+annawinkler@users.noreply.github.com>
Co-authored-by: Sebastian Rivera <sebastian.rivera@hashicorp.com>
138802f
to
9dd27b2
Compare
9dd27b2
to
fd0b70e
Compare
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
Repurposes the json-state field to only include json outputs
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.