New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query option to agent pool list options #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and easy 🔥 ! Just missing the code documentation for the field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really minor ⬇️
e7e5f9a
to
827e3c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed something ⬇️ , the test is failing in CI which means the query param is not available in tflocal.
@@ -68,6 +68,21 @@ func TestAgentPoolsList(t *testing.T) { | |||
assert.Nil(t, pools) | |||
assert.EqualError(t, err, ErrInvalidOrg.Error()) | |||
}) | |||
|
|||
t.Run("with query options", func(t *testing.T) { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I believe you mentioned this query param was sitting behind a feature flag... in which case skipIfBeta(t)
test helper will need to be added to this subtest otherwise the test will fail in CI... I don't think tflocal has the flag enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebasslash sorry, took a vacation and let this review sit for a bit. The flag is now on in production, and it looks like we are seeing the tests pass!
67cfe84
to
ed40f7a
Compare
074922e
to
adbb021
Compare
adbb021
to
62d1a46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM once the tests are passing (the one failure looks like a flake).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Looks good to me
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
Add query option to agent pool list options
This will be blocked until the agent pool search feature is enabled (feature flag:
remove-agent-pool-limit
)Testing plan
This code is exercised by an upcoming TFE provider change. It can be used to make the tfe_agent_pool data source much more efficient in organizations with more than 20 agents
External links
Output from tests