Validate the module version as version instead of ID #409
Conversation
svanharmelen
force-pushed
the
bugfix/module-version
branch
from
d2e5106
to
30139e6
Compare
| _, err := mail.ParseAddress(v) | ||
| // validVersion checks if the given input is a valid version. | ||
| func validVersion(v string) bool { | ||
| _, err := version.NewVersion(v) |
There was a problem hiding this comment.
This is a neat trick! Wasn't aware we could leverage this, very cool :D
svanharmelen
force-pushed
the
bugfix/module-version
branch
from
30139e6
to
c586b46
Compare
|
Rebased to fix the merge conflicts... |
|
Hi @svanharmelen - could you please update your fork with main? We'd like to get this PR merged. Thank you! 🥳 |
svanharmelen
force-pushed
the
bugfix/module-version
branch
from
c586b46
to
7d61498
Compare
|
@annawinkler done... Noticed the integration tests failed, but its because of a missing token so don't think it's related to the changed in the PR 🤷🏻♂️ |
|
@svanharmelen Thank you! Yes, we'll take a look at that. |
|
@annawinkler It is approved now, can this also be merged and released? Would be nice if we can remove our forked repo out of ecosystem 😉 |
Without these changes a module version with prerelease or metadata will fail, while these are actually valid SemVer versions that are allowed by the module registry.
svanharmelen
force-pushed
the
bugfix/module-version
branch
from
7d61498
to
72de0b5
Compare
|
Opened a new PR #571 so I can get tests to run. Will close this PR after the new one is merged. |
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Add changelog entry for #409
Without these changes a module version with prerelease or metadata will fail, while these are actually valid SemVer versions that are allowed by the module registry.
The PR includes tests that fail without the additional code changes, so everything that is needed should be in here...