Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add List Registry Modules Endpoint #385

Merged
merged 4 commits into from Jun 8, 2022
Merged

Add List Registry Modules Endpoint #385

merged 4 commits into from Jun 8, 2022

Conversation

chroju
Copy link
Contributor

@chroju chroju commented Apr 23, 2022

Description

Add a support for List Registry Modules for an Organization API endpoint.

Testing plan

  1. Create an organization.
  2. Create some registry modules.
  3. Query the registry modules.

External links

Output from tests (HashiCorp employees only)

N/A

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 23, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@chroju chroju changed the title Add registry module list Add List Registry Modules Endpoint Apr 23, 2022
sebasslash
sebasslash previously requested changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! Since you've added new endpoints to an existing resource you'll need to re-generate the mocks. You can do so running ./generate-mocks.sh and then just push the edited files.

@sebasslash
Copy link
Contributor

Oh forgot to mention, you'll need to rebase with main to fix the CI test failures!

@chroju
Copy link
Contributor Author

chroju commented Apr 28, 2022

@sebasslash
Thanks a lot! I have merged main to this branch and re-generated the mocks.

@chroju chroju requested a review from sebasslash April 28, 2022 04:12
@sebasslash sebasslash dismissed their stale review June 7, 2022 21:35

Changes addressed

sebasslash
sebasslash approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏇 🏁

@sebasslash sebasslash merged commit 5a2a37b into hashicorp:main Jun 8, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

@chroju chroju deleted the add_registry_module_list branch June 13, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebasslash sebasslash sebasslash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List Registry Modules
3 participants
@chroju @hashicorp-cla @sebasslash