Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new states and endpoint for configuration version archiving #338

Merged
merged 4 commits into from Mar 16, 2022

Conversation

mpminardi
Copy link
Contributor

@mpminardi mpminardi commented Feb 28, 2022

Description

Adds the new fetching status to run and the new archived status to configuration version that have been introduced as part of new configuration version archival functionality.

Also adds the Archive method to the ConfigurationVersions interface to allow for hitting this new endpoint.

Testing plan

External links

Output from tests (HashiCorp employees only)

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" TF_ACC="1" go test -run TestConfigurationVersionsArchive -v ./... -tags=integration
=== RUN   TestConfigurationVersionsArchive
=== RUN   TestConfigurationVersionsArchive/when_the_configuration_version_exists_and_has_been_uploaded
=== RUN   TestConfigurationVersionsArchive/when_the_configuration_version_does_not_exist
=== RUN   TestConfigurationVersionsArchive/with_invalid_configuration_version_id
--- PASS: TestConfigurationVersionsArchive (3.75s)
    --- PASS: TestConfigurationVersionsArchive/when_the_configuration_version_exists_and_has_been_uploaded (1.18s)
    --- PASS: TestConfigurationVersionsArchive/when_the_configuration_version_does_not_exist (0.21s)
    --- PASS: TestConfigurationVersionsArchive/with_invalid_configuration_version_id (0.00s)
PASS

@mpminardi mpminardi added the wip Work in progress label Feb 28, 2022
@mpminardi mpminardi requested a review from a team February 28, 2022 23:59
@mpminardi mpminardi self-assigned this Feb 28, 2022
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@mpminardi mpminardi added enhancement New feature or request and removed wip Work in progress labels Mar 14, 2022
@mpminardi mpminardi marked this pull request as ready for review March 14, 2022 16:50
@mpminardi mpminardi force-pushed the mpminardi/archive-config-versions branch from 756561e to 9a3dbab Compare March 14, 2022 18:51
@mpminardi mpminardi changed the base branch from main to releases-1.0.x March 14, 2022 18:51
@mpminardi mpminardi merged commit 6590bf1 into releases-1.0.x Mar 16, 2022
@mpminardi mpminardi deleted the mpminardi/archive-config-versions branch March 16, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release-1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants