Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds AgentsCeilingOverride and RunsCeilingOverride fields in AdminOrganization and AdminOrganizationUpdateOptions structs #836

Closed
wants to merge 1 commit into from

Conversation

alex-ikse
Copy link
Contributor

Description

Add undocumented agents-ceiling-override and runs-ceiling-override attributes to Organization admin.

Testing plan

Used in a modified version of the tfe provider.

External links

@alex-ikse alex-ikse requested a review from a team as a code owner January 16, 2024 14:17
@brandonc
Copy link
Collaborator

I'm sort of confused about this addition so maybe you can help me understand! My understanding of these attributes in particular is that they are not documented nor relevant to Terraform Enterprise and using them requires internal (HashiCorp) access to read and write them in Terraform Cloud. How could it be effective for you if these appear in the SDK?

@alex-ikse
Copy link
Contributor Author

I'm sort of confused about this addition so maybe you can help me understand! My understanding of these attributes in particular is that they are not documented nor relevant to Terraform Enterprise and using them requires internal (HashiCorp) access to read and write them in Terraform Cloud. How could it be effective for you if these appear in the SDK?

Theses settings are available in TFE admin organization page.
Capture d’écran 2024-01-17 à 23 20 25

@brandonc
Copy link
Collaborator

brandonc commented Jan 18, 2024

@alex-ikse There's something strange going on that I am still missing. My reading of the code, my testing, and my inquiries on the topic seem to agree that you should not see this UI because your orgs are not meant to have a subscription that this UI is predicated on. I wonder if you could share with me the result of this API query?

GET /api/v2/organizations/<org name>/subscription

If this returns a successful response, it means you have an active subscription. I'm trying to work out how you may have a subscription enabled for this organization. So far I've been unable to reproduce this situation. Thanks!

At the end of the day, this change shouldn't be needed for go-tfe but I'm curious if there is a different bug that allowed you to create a subscription.

@alex-ikse
Copy link
Contributor Author

GET /api/v2/organizations/<org name>/subscription

@brandonc : This endpoint doesn't exists on Terraform Enterprise.

…anization and AdminOrganizationUpdateOptions structs
@alex-ikse
Copy link
Contributor Author

GET /api/v2/organizations/<org name>/subscription

@brandonc : This endpoint doesn't exists on Terraform Enterprise.

any news @brandonc ?

@brandonc
Copy link
Collaborator

brandonc commented Feb 1, 2024

@alex-ikse Thanks for checking that for me. If you got a 404 from that endpoint, it likely means that you don't have a subscription associated with that organization-- this is what would be expected but also further deepens the mystery about why you are seeing the UI. I'm going to advise the appropriate team inside HashiCorp to use a cloud condition around that UI because it is not relevant to Terraform Enterprise and as such should also not be an option in this SDK.

@brandonc brandonc closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants