Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tokens for admin roles in the environment #699

Merged
merged 2 commits into from
May 12, 2023

Conversation

annawinkler
Copy link
Contributor

Description

We output admin tokens by role, so let's take that and set an environment variable to use in future tests.

Testing plan

  1. Nothing should change.

@annawinkler annawinkler requested a review from a team as a code owner May 9, 2023 21:23
sebasslash
sebasslash previously approved these changes May 9, 2023
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@annawinkler annawinkler force-pushed the aw/TF-5841-set-admin-role-token branch 2 times, most recently from bb70d6b to 5831f81 Compare May 10, 2023 21:38
@annawinkler annawinkler changed the title Set admin token by role in the environment Set tokens for admin roles in the environment May 11, 2023
@annawinkler annawinkler force-pushed the aw/TF-5841-set-admin-role-token branch from 5831f81 to 0583ff9 Compare May 11, 2023 20:29
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@annawinkler annawinkler force-pushed the aw/TF-5841-set-admin-role-token branch from 0583ff9 to cc76720 Compare May 11, 2023 21:54
@brandonc
Copy link
Collaborator

Closing this for now because the branch exposes test infra secrets. (Previously revealed tokens have been revoked)

@brandonc brandonc closed this May 11, 2023
@annawinkler annawinkler reopened this May 12, 2023
brandonc
brandonc previously approved these changes May 12, 2023
@@ -28,7 +28,7 @@ jobs:
steps:
- name: terraform-cloud-outputs
id: tflocal
uses: hashicorp-forge/terraform-cloud-action/outputs@v1
uses: hashicorp-forge/terraform-cloud-action/outputs@4adbe7eea886138ac10a4c09e63c5c568aaa6672
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked!

Screenshot 2023-05-12 at 10 36 06 AM

Nit: can you pin all the terraform-cloud-action/ actions to 4adbe7eea886138ac10a4c09e63c5c568aaa6672 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that not all of the tokens were listed so I fixed the reference to use hyphens for real (in my mind I always translate - to _)

@annawinkler annawinkler force-pushed the aw/TF-5841-set-admin-role-token branch from fa3fede to 9c9c286 Compare May 12, 2023 17:23
@annawinkler annawinkler merged commit 0ee9080 into main May 12, 2023
10 checks passed
@annawinkler annawinkler deleted the aw/TF-5841-set-admin-role-token branch May 12, 2023 20:37
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants