-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TF-5841] Use TFC admin role tokens in tests #696
Conversation
3940299
to
8b1f2d3
Compare
2439361
to
2f8ba30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the overall implementation here is 🔥 and has my approval pending some minor cleanup
4b54e05
to
8bfe15b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There's a couple extra blank lines in random spots here, probably leftovers from removing the debug printfs, but I won't block on em. If you want to remove them tho, ping me and I'll re-✅ asap.
8bfe15b
to
879a98b
Compare
Good call re the newlines! I removed them - could you please re-approve? Thanks! |
879a98b
to
47d3aad
Compare
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
Use the TFC Admin Role tokens for tests.
Testing plan
If you're testing with a local tfcdev instance, you'll want to use the branch in the Related PR.
TFE_TOKEN
to that value (I'm using the envchain env calledtfe-local
to manage my local env vars). Invoke the following test where TOKEN is the token you just created.The test should fail.
provision-licenses
admin role:Rerun the test again and it should pass.
I also ran the admin tests against staging (I enabled the feature flag on staging):
and the tests passed with this branch.
External links
Output from tests
I ran these tests locally:
TestGPGKey
Command
Output
TestRegistryProvider
Command
Output
TestPolicySet
Command
Output
Note - the failures are because my environment is not setup correctly for the VCS related tests.