Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for querying run events #680

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Add support for querying run events #680

merged 4 commits into from
Apr 11, 2023

Conversation

glennsarti
Copy link
Contributor

@glennsarti glennsarti commented Apr 11, 2023

Description

This commit adds API support for querying the List and Read of run-events.

Testing plan

Integration tests are sufficient

External links

The API docs only tangentially refer to run-events as per the example response payload. Unfortunately the run-events API endpoint is currently undocumented.

Output from tests

=== RUN   TestRunEventsList
=== RUN   TestRunEventsList/without_list_options
=== RUN   TestRunEventsList/with_all_includes
=== RUN   TestRunEventsList/without_a_valid_run_ID
--- PASS: TestRunEventsList (5.55s)
    --- PASS: TestRunEventsList/without_list_options (0.39s)
    --- PASS: TestRunEventsList/with_all_includes (0.47s)
    --- PASS: TestRunEventsList/without_a_valid_run_ID (0.00s)
=== RUN   TestRunEventsRead
=== RUN   TestRunEventsRead/without_read_options
=== RUN   TestRunEventsRead/with_all_includes
=== RUN   TestRunEventsRead/without_a_valid_run_event_ID
--- PASS: TestRunEventsRead (5.97s)
    --- PASS: TestRunEventsRead/without_read_options (0.32s)
    --- PASS: TestRunEventsRead/with_all_includes (0.31s)
    --- PASS: TestRunEventsRead/without_a_valid_run_event_ID (0.00s)

@glennsarti glennsarti requested a review from a team as a code owner April 11, 2023 08:34
@glennsarti glennsarti self-assigned this Apr 11, 2023
This commit adds API support for querying the List and Read of run-events.
@glennsarti
Copy link
Contributor Author

CI failures seem unrelated

Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a CHANGELOG entry?

run_event.go Outdated Show resolved Hide resolved
run_event.go Outdated Show resolved Hide resolved
run_event.go Outdated Show resolved Hide resolved
run_event.go Outdated Show resolved Hide resolved
run_event.go Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy

@sebasslash
Copy link
Contributor

Please rebase with main to fix CI failures 👍

brandonc
brandonc previously approved these changes Apr 11, 2023
@brandonc brandonc merged commit 3429064 into main Apr 11, 2023
9 checks passed
@brandonc brandonc deleted the gs/add-run-events branch April 11, 2023 20:14
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

@brandonc
Copy link
Collaborator

@glennsarti I hope you don't mind I went ahead and merged this because we are prepping a release.

@glennsarti
Copy link
Contributor Author

@brandonc Al good. Thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants