Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates VariableSetReadOptions tag to allow including vars and… #678

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

sgap
Copy link

@sgap sgap commented Apr 10, 2023

workspaces in the VariableSets.Read response

Description

This change fixes an issue where VariableSets.Read does not honor the VariableSetReadOptions.Include values due to a syntax error in the struct tag of VariableSetReadOptions.

Testing plan

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

… `workspaces` in the VariableSets.Read response
@sgap sgap requested a review from a team as a code owner April 10, 2023 16:23
@hashicorp-cla
Copy link

hashicorp-cla commented Apr 10, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 Thank you

@brandonc brandonc merged commit 08114e9 into hashicorp:main Apr 10, 2023
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

@brandonc
Copy link
Collaborator

This fix was released in v1.21.0

@sgap sgap deleted the patch-varset-include branch January 14, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants