New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Add go fmt check to linter #606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good to me ✔️
I have a suggestion on the wording in our docs ⬇️
vet: | ||
go vet | ||
|
||
fmt: | ||
go fmt ./... | ||
gofmt -s -l -w . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context:
-s
tells gofmt
to simplify your code
-l
tells gofmt
to list the files that changed due to formatting
-w
tells gofmt
to write the formatting changes to the source file
Run gofmt -help
for more info!
a265ce6
to
df0694c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, like this wording much better 🔥
df0694c
to
7155a4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
No description provided.