Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Add go fmt check to linter #606

Merged
merged 2 commits into from Dec 8, 2022
Merged

Conversation

brandonc
Copy link
Collaborator

@brandonc brandonc commented Dec 7, 2022

No description provided.

@brandonc brandonc requested a review from a team as a code owner December 7, 2022 20:58
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good to me ✔️

I have a suggestion on the wording in our docs ⬇️

vet:
go vet

fmt:
go fmt ./...
gofmt -s -l -w .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context:
-s tells gofmt to simplify your code
-l tells gofmt to list the files that changed due to formatting
-w tells gofmt to write the formatting changes to the source file

Run gofmt -help for more info!

docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
@brandonc brandonc force-pushed the brandonc/TF-2774_fmt_ci branch 2 times, most recently from a265ce6 to df0694c Compare December 7, 2022 21:21
sebasslash
sebasslash previously approved these changes Dec 7, 2022
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, like this wording much better 🔥

Copy link
Contributor

@annawinkler annawinkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brandonc brandonc merged commit 3ac0491 into main Dec 8, 2022
@brandonc brandonc deleted the brandonc/TF-2774_fmt_ci branch December 8, 2022 18:25
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants