Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: skipIfBeta is worded as the opposite logic #598

Merged
merged 4 commits into from Dec 1, 2022
Merged

Conversation

brandonc
Copy link
Collaborator

Also prefer "skipUnless" to "skipIfNot"

@brandonc brandonc requested a review from a team as a code owner November 30, 2022 19:49
helper_test.go Show resolved Hide resolved
Copy link
Contributor

@Uk1288 Uk1288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Looks good to me.

@brandonc brandonc merged commit d2e0e00 into main Dec 1, 2022
@brandonc brandonc deleted the brandon/skipUnless branch December 1, 2022 17:43
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants