Fix or ignore all outsanding golangci-lint errors #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
As reported by "make lint" Also fixed incorrect build tag in two tests that were causing the tests to be skipped Thanks to @estenssoros for the efforts to improve the code! Co-Authored-By: Sebastian Estenssoro <seb.estenssoro@gmail.com>
brandonc
force-pushed
the
brandonc/fix_linter
branch
from
ded4666
to
983c77a
Compare
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...As reported by "make lint"
Also fixed incorrect build tag in two tests that were causing the tests to be skipped, which linting should have caught (!!!)
Thanks to @estenssoros for the efforts to improve the code!
Co-Authored-By: Sebastian Estenssoro seb.estenssoro@gmail.com