Add search[wildcard-name] to WorkspaceListOptions #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenolivia
force-pushed
the
laurenolivia/update-workspace-list-options
branch
from
706731d
to
3e69e1d
Compare
annawinkler
reviewed
Oct 31, 2022
|
@laurenolivia This looks good! 🥇 Do you want to update the changelog in this PR too? |
|
Yep, will do! Looks like a couple tests failed, but they pass locally. Will look into that, and also update the changelog. Thanks. |
laurenolivia
changed the title
laurenolivia
force-pushed
the
laurenolivia/update-workspace-list-options
branch
from
f3191aa
to
641d87f
Compare
annawinkler
reviewed
Nov 2, 2022
laurenolivia
force-pushed
the
laurenolivia/update-workspace-list-options
branch
from
641d87f
to
4c23de2
Compare
brandonc
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Will need to rebase #578 if this is merged before release is cut @annawinkler
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes the new optional query param
search[wildcard-name]. See List Workspaces docs.Testing plan
N/A
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.