Add query option to agent pool list options #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebasslash
requested changes
May 31, 2022
JarrettSpiker
force-pushed
the
jspiker/agent-pool-search
branch
2 times, most recently
from
e7e5f9a
to
827e3c4
Compare
sebasslash
requested changes
Jun 8, 2022
| @@ -68,6 +68,21 @@ func TestAgentPoolsList(t *testing.T) { | |||
| assert.Nil(t, pools) | |||
| assert.EqualError(t, err, ErrInvalidOrg.Error()) | |||
| }) | |||
|
|
|||
| t.Run("with query options", func(t *testing.T) { | |||
|
|
|||
There was a problem hiding this comment.
Ah, I believe you mentioned this query param was sitting behind a feature flag... in which case skipIfBeta(t) test helper will need to be added to this subtest otherwise the test will fail in CI... I don't think tflocal has the flag enabled?
There was a problem hiding this comment.
@sebasslash sorry, took a vacation and let this review sit for a bit. The flag is now on in production, and it looks like we are seeing the tests pass!
JarrettSpiker
force-pushed
the
jspiker/agent-pool-search
branch
3 times, most recently
from
67cfe84
to
ed40f7a
Compare
JarrettSpiker
force-pushed
the
jspiker/agent-pool-search
branch
2 times, most recently
from
074922e
to
adbb021
Compare
JarrettSpiker
force-pushed
the
jspiker/agent-pool-search
branch
from
adbb021
to
62d1a46
Compare
mpminardi
approved these changes
Jul 12, 2022
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add query option to agent pool list options
This will be blocked until the agent pool search feature is enabled (feature flag:
remove-agent-pool-limit)Testing plan
This code is exercised by an upcoming TFE provider change. It can be used to make the tfe_agent_pool data source much more efficient in organizations with more than 20 agents
External links
Output from tests