Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove branch from github actions #363

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

uturunku1
Copy link
Collaborator

@uturunku1 uturunku1 commented Mar 18, 2022

We are done using the releases 1.0 branch for now. The branch itself has not been deleted because is possible we want to go back to it in the future. But for now I am removing this branch from our PR checks (specifically the github actions one) before I forget that we need to remove it.
Lots of tests failing right now: Looks like the nightly build for the platform is running.

Description

Testing plan

External links

Output from tests (HashiCorp employees only)

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" TF_ACC="1" go test ./... -v -tags=integration -run TestFunctionsAffectedByChange

...

sebasslash
sebasslash previously approved these changes Mar 21, 2022
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad to see it go 😢

Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@uturunku1 uturunku1 merged commit 3174fa6 into main Mar 22, 2022
@uturunku1 uturunku1 deleted the remove-release1.0branch-ghworkflows branch March 22, 2022 19:52
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants