Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should ConfigurationSource contants include ado for Azure DevOps? #148

Closed
rberlind opened this issue Oct 30, 2020 · 1 comment
Closed

Should ConfigurationSource contants include ado for Azure DevOps? #148

rberlind opened this issue Oct 30, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rberlind
Copy link

In https://github.com/hashicorp/go-tfe/blob/master/configuration_version.go#L59 we list several ConfigurationSource strings including "tfe-api" for the TFE API, "terraform" (for the TFC UI?) and "bitbucket", "github", and "gitlab". But should we also include "ado" in case the VCS system is Azure DevOps Server or Azure DevOps Services? See https://www.terraform.io/docs/cloud/vcs/index.html#supported-vcs-providers

I'm asking because I am adding a new policy_set_version class and wonder if I should include "ado" there.

@barrettclark barrettclark added enhancement New feature or request good first issue Good for newcomers labels Jul 14, 2022
@barrettclark
Copy link
Contributor

#467 addresses this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants