Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gzip compression level to BestSpeed (1) #31

Merged
merged 1 commit into from Nov 23, 2022
Merged

Conversation

brandonc
Copy link
Contributor

@brandonc brandonc commented Sep 22, 2022

We notice that compression time far exceeds upload time in practice, and think it should be re-balanced toward less compression. I have some analytics that I can share that illustrate this in downstream tfc-agent.

We notice that compression time far exceeds upload time in practice,
and think it should be re-balanced toward less compression
Copy link

@annawinkler annawinkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me, but I'd really like someone more familiar with the repo to also review.

@brandonc brandonc merged commit 2777fe2 into master Nov 23, 2022
@xiehan xiehan deleted the brandonc/best_speed branch May 8, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants