Propagate plugin options in ConfigureWrapper #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testplugin as previously implemented didn't support the Encrypt or Decrypt methods, since it did not have an AEAD cipher configured. This change configures an AES cipher with a hardcoded key, so that we can do Encrypt and Decrypt operations in tests.
The configureWrapper was not propagating plugin options. Propagate these options and add a test to ensure they work.
tmessi
reviewed
Jun 28, 2022
jimlambrt
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we forgot to include this when migrating to the new kms wrapper in #32.
fix: Make testplugin functional
The testplugin as previously implemented didn't support the Encrypt or Decrypt methods, since it did not have an AEAD cipher configured. This change configures an AES cipher with a hardcoded key, so that we can do Encrypt
and Decrypt operations in tests.
fix: Propagate plugin options in configureWrapper
The configureWrapper was not propagating plugin options. Propagate these options and add a test to ensure they work.