bug(parseutil): SafeParseIntSlice leading zeros #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to creating a slice with the specified number of elements (rather than a capacity hint), SafeParseIntSlice returned a slice with leading zeros of length greater than was passed, rather than the correct value. Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
sgmiller
approved these changes
May 31, 2022
|
1.12.x will happen naturally, but make sure to create a PR to update the deps for 1.11. |
cipherboy
added a commit
to hashicorp/vault
that referenced
this pull request
Jun 2, 2022
Note that this only really applies to the SSH engine, nothing else uses this helper. Other go.mod's updated for consistency. See also: hashicorp/go-secure-stdlib#40 Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
added a commit
to hashicorp/vault
that referenced
this pull request
Jun 2, 2022
Note that this only really applies to the SSH engine, nothing else uses this helper. Other go.mod's updated for consistency. See also: hashicorp/go-secure-stdlib#40 Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
Note that this only really applies to the SSH engine, nothing else uses this helper. Other go.mod's updated for consistency. See also: hashicorp/go-secure-stdlib#40 Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to creating a slice with the specified number of elements (rather
than a capacity hint),
SafeParseIntSlicereturned a slice with leadingzeros of length greater than was passed, rather than the correct value.
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>Of course, the one function I didn't test has the bug... Thanks to @Gabrielopesantos in hashicorp/vault#15561 for catching this!
@sgmiller We'll need to bump this in Vault on both 1.12.x and 1.11.x.