adding fileutil #38
Merged
adding fileutil #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for sharing caching file reader
5 tasks
tomhjp
previously approved these changes
Apr 14, 2022
Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
tomhjp
previously approved these changes
Apr 14, 2022
swenson
previously approved these changes
Apr 14, 2022
…into VAULT-5669/caching-file-reader
and protect time updates in the test
Use []byte instead of string to store the contents of the file, and always return a copy from ReadFile().
calvn
approved these changes
Apr 18, 2022
tomhjp
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a fileutil package, mainly for the purpose of sharing the caching file reader from https://github.com/hashicorp/vault-plugin-auth-kubernetes/blob/main/caching_file_reader.go